Skip to content

jQuery.param: Removed details about traditional flag #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

AurelioDeRosa
Copy link
Member

Fixes gh-919

@dmethvin
Copy link
Member

dmethvin commented May 6, 2016

LGTM, it just needs to be moved to the 3.0 branch and the existing wording is fine.

@AurelioDeRosa
Copy link
Member Author

I was thinking that but because we forked it so long ago, in branch v3 we still have the text.

@dmethvin
Copy link
Member

dmethvin commented May 6, 2016

Oh true, although it still says 1.8 right?

@AurelioDeRosa
Copy link
Member Author

Oh, true. I think I'm going to rebase the branch today because it's now very old. Once done that, I'm going to submit a PR to address it.

AurelioDeRosa added a commit to AurelioDeRosa/api.jquery.com that referenced this pull request May 20, 2016
@AurelioDeRosa
Copy link
Member Author

I've submitted PR #932 to address the last problem left with this PR, so it's now good to merge.

AurelioDeRosa added a commit that referenced this pull request May 22, 2016
AurelioDeRosa added a commit that referenced this pull request May 23, 2016
@AurelioDeRosa AurelioDeRosa deleted the traditional branch June 1, 2016 11:16
timmywil pushed a commit that referenced this pull request Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants